Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final @jfy133 review fixes for Bouncy Basenji release #531

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Final @jfy133 review fixes for Bouncy Basenji release #531

merged 5 commits into from
Sep 25, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Sep 19, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0c647d1

+| ✅ 267 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.2
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-25 10:17:54

@jfy133 jfy133 mentioned this pull request Sep 19, 2024
Merged
11 tasks
LilyAnderssonLee
LilyAnderssonLee approved these changes Sep 25, 2024
View reviewed changes
assets/multiqc_config.yml
- "_R2"
- type: regex
pattern: "[_.-][rR]?2$"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!!! Is it possible to share the MultiQC report? I am very curious how the new one looks like.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAha, I just copied from the MultiQC docs from the new functionality page, but sure!

It's still not perfect - if I removed _raw it would collapse everything and not have the expansion thingy

multiqc_.zip

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. It's better to keep _raw.
I didn't see Nonpareil in the MultiQC report.

@jfy133 jfy133 merged commit f9f9b18 into dev Sep 25, 2024
24 checks passed
@jfy133 jfy133 deleted the jfy133-review-fixes branch September 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyAnderssonLee LilyAnderssonLee LilyAnderssonLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @LilyAnderssonLee