Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generating mag samplesheet #544
base: dev
Are you sure you want to change the base?
Add support for generating mag samplesheet #544
Changes from 17 commits
b0b37eb
590f9b1
738837e
3d19176
80bed68
4a9fa88
a3dea86
b0ceef7
b5fe3db
a1cab25
c315cae
cd136d7
7acbc4b
263c7d3
e3fa0ee
c6ac0cb
aff979e
67f33e5
94a28f4
892b428
e0e83c3
0abfdf7
1e00c4c
f79fc7d
7a25178
b729483
6eeb982
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing differential abundance? @LilyAnderssonLee do you thin kyou could merge your PR into this one at this stage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you not also make this support single_end using the
meta.single_end
information?Or have we lost that information at this stage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not follow here. We said to filter out the single ends and fasta. Or do I misunderstand something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, good point I forgot and there wasn't a comment why 😅
Please leave a comment next to the line saying only PE supported now, and I'll look into fixing that later :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sofstam did you see what @Joon-Klaps did in detaxizer for SE/PE reads? You can copy the same concept here too (basically to branch SE/PE separately, and call the
channelToSamplesheet
function twice ;)