Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important! Template update for nf-core/tools v3.0.2 #545

Merged
merged 20 commits into from
Oct 24, 2024

Conversation

nf-core-bot
Copy link
Member

Version 3.0.2 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-3.0.2 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v3.0.2 release page.

Copy link

github-actions bot commented Oct 17, 2024

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 00067f5

+| ✅ 281 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-24 09:15:24

@LilyAnderssonLee
Copy link
Contributor

A full test was run locally and it passed.

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to make a few broken samplesheets and upload to the test-data repo so we can double check the schema is working like I did here: nf-core/test-datasets#1350

Did you also check that all our meta condition checks like meta.<xxx> == null or !meta.<xxx> for optional meta fields are OK, and tags look OK, no random [] empty strings, given https://nfcore.slack.com/archives/C056RQB10LU/p1729069030926369?

I

.nf-core.yml Outdated Show resolved Hide resolved
CITATIONS.md Outdated Show resolved Hide resolved
assets/schema_database.json Show resolved Hide resolved
assets/schema_input.json Outdated Show resolved Hide resolved
assets/schema_input.json Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
conf/test_alternativepreprocessing.config Outdated Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! I just need to fix the test requirements in the repo settings :)

assets/schema_input.json Show resolved Hide resolved
conf/test_bbduk.config Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
.nf-core.yml Outdated Show resolved Hide resolved
LilyAnderssonLee and others added 2 commits October 24, 2024 09:45
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
@jfy133
Copy link
Member

jfy133 commented Oct 24, 2024

@nf-core-bot fix linting

@LilyAnderssonLee
Copy link
Contributor

Added broken samplesheets and databases to test input and database schema nf-core/test-datasets#1357

@jfy133 jfy133 self-requested a review October 24, 2024 09:23
@LilyAnderssonLee LilyAnderssonLee merged commit e34437b into dev Oct 24, 2024
26 checks passed
@LilyAnderssonLee LilyAnderssonLee deleted the nf-core-template-merge-3.0.2 branch October 24, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants