Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nf-core logos #1894

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Update nf-core logos #1894

merged 3 commits into from
Jul 25, 2023

Conversation

mribeirodantas
Copy link
Member

Fix buggy dash in teh nf-core logo

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for nf-core ready!

Name Link
🔨 Latest commit b3c4ef1
🔍 Latest deploy log https://app.netlify.com/sites/nf-core/deploys/64bfb873ed4e780008ec38b0
😎 Deploy Preview https://deploy-preview-1894--nf-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mribeirodantas
Copy link
Member Author

I don't know much about Astro, so I'm trying to fix the image size without bugging the dash 😅 WIP

@mribeirodantas mribeirodantas marked this pull request as draft July 24, 2023 19:46
Fix buggy dash in teh nf-core logo

Signed-off-by: Marcel Ribeiro-Dantas <[email protected]>
@mashehu
Copy link
Contributor

mashehu commented Jul 25, 2023

I don't see this bug on any of my browsers. can you check with the updated svgs?

@mribeirodantas
Copy link
Member Author

It's working now, @mashehu 🥳.

As for the bug, you should be able to reproduce it on Safari (Version 17.0 (19616.1.20.11.3) here)

@mribeirodantas mribeirodantas marked this pull request as ready for review July 25, 2023 11:56
@mribeirodantas mribeirodantas merged commit a9e7501 into main Jul 25, 2023
5 checks passed
@mribeirodantas mribeirodantas deleted the update-logos branch July 25, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants