-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve recommendations on publication credit #2839
Open
mribeirodantas
wants to merge
4
commits into
main
Choose a base branch
from
improve-recommendations-publication
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bb6ef70
Improve recommendations on publication credit
mribeirodantas 61cb6f2
Merge branch 'main' into improve-recommendations-publication
mribeirodantas 27c4d2b
Update sites/docs/src/content/docs/guidelines/pipelines/recommendatio…
mribeirodantas 2cba77c
Merge branch 'main' into improve-recommendations-publication
mribeirodantas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think? @christopher-hakkaart @jfy133 @sateeshperi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this link. It expands on the criteria a little. I find the clause about not granting authorship to anyone not involved in the manuscript drafting to be a little strict. I would drop the second bullet point.
Maybe this is a discussion for the next core team meeting? Get lots of eyes on it as this is a reasonably large decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't read but might also be worth a skim this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However I still don't really like this, it's being too proscriptive and I worry about might put people off contributing pipelines to nf-core if they (PIs) are worried about the risk of getting into protracted arguments about authorships or feel that it's no-longer their pipeline and they include the publication with their thesis etc.
Furthmore, it could be someone wants authorship to recognise their contribution, but they don't care about the drafting the actual publication (it's not their job), so the 'AND' is going to make that difficult. Furthermore, someone may not want to be accountable for all aspects of the work if it's some other lab who has done lab work analysis etc. in the publication.
To be clear: conceptually it is nice, but I don't feel we can control this.
We already have problems tracking all developers, if we now have to chase them to make sure they are following
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I guess it all comes back to what constitutes a substantial contribution and how to encourage thoughtful consideration for authorship in different scenarios. Maybe we could give some examples.
Something something something... substantial contribution. For example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would work with examples. But ensure the wording is that they are just suggestions to help you decide/evaluate