Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NX #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Migrate NX #98

wants to merge 2 commits into from

Conversation

mahmut-gundogdu
Copy link
Contributor

@mahmut-gundogdu mahmut-gundogdu commented Nov 20, 2022

  • Repo moved to nx (with ng add @nrwl/angular --preserve-angular-cli-layout)
  • Validators moved to sepereated package.

todo:
[ ] Add build target to validators
[ ] Add ng-packages

@mahmut-gundogdu mahmut-gundogdu marked this pull request as ready for review November 20, 2022 20:26
Copy link
Member

@muhammedaltug muhammedaltug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ng-package.json is missing in validators package

"prefix": "ngx-validate",
"targets": {
"test": {
"executor": "@nrwl/jest:jest",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test executor different from other packages' test executor.

"@angular/common": ">=5.0.0",
"@angular/core": ">=5.0.0",
"@angular/forms": ">=5.0.0",
"rxjs": ">=6.0.0 || ^5.6.0-forward-compat.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depended rxjs version is 7.5.0

Comment on lines +13 to +15
"@angular/common": ">=5.0.0",
"@angular/core": ">=5.0.0",
"@angular/forms": ">=5.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depended angular version is 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants