Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LINQ Nullable in WHERE condition tests #3158

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

LINQ Nullable in WHERE condition tests #3158

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e65bc1
LINQ Nullable in WHERE condition tests
krzkowal Sep 12, 2022
e47c3a6
Generate async files
github-actions[bot] Sep 12, 2022
80c0155
Merge branch 'master' into 3156
hazzik Sep 14, 2022
f6785d5
Merge branch 'master' into 3156
krzkowal Nov 29, 2022
b7a8ac8
Merge branch 'master' into 3156
krzkowal Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/NHibernate.Test/Async/Linq/WhereTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,28 @@ from o in session.Query<User>()
Assert.That(query.Count, Is.EqualTo(3));
}

[Test(Description = "GH-3156")]
public void CanUseNullableWithoutAValueAsync()
{
bool? isActive = null;

Assert.DoesNotThrowAsync(
async () => _ = await (session.Query<Role>()
.Where(r => !isActive.HasValue || r.IsActive == isActive.Value)
.ToListAsync()));
}

[Test(Description = "GH-3156")]
public void CanUseNullableWithoutAValue2Async()
{
bool? isActive = null;

Assert.DoesNotThrowAsync(
async () => _ = await (session.Query<Role>()
.Where(r => isActive == null || r.IsActive == isActive.Value)
.ToListAsync()));
}

[Test(Description = "NH-2375")]
public async Task OfTypeWithWhereAndProjectionAsync()
{
Expand Down
22 changes: 22 additions & 0 deletions src/NHibernate.Test/Linq/WhereTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,28 @@ from o in session.Query<User>()
Assert.That(query.Count, Is.EqualTo(3));
}

[Test(Description = "GH-3156")]
public void CanUseNullableWithoutAValue()
{
bool? isActive = null;

Assert.DoesNotThrow(
() => _ = session.Query<Role>()
.Where(r => !isActive.HasValue || r.IsActive == isActive.Value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing .Value on a null parameter remains unsupported, but that is not a regression. And it is a minimal priority issue in my opinion, since this .Value access is not needed and has not any advantage as far as I know.

.ToList());
}

[Test(Description = "GH-3156")]
public void CanUseNullableWithoutAValue2()
{
bool? isActive = null;

Assert.DoesNotThrow(
() => _ = session.Query<Role>()
.Where(r => isActive == null || r.IsActive == isActive.Value)
.ToList());
}

[Test(Description = "NH-2375")]
public void OfTypeWithWhereAndProjection()
{
Expand Down