Add Unused Code check to VI Analyzer workflow
#462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aepete
requested review from
dixonjoel,
pbirkhol-ni and
jasonmreding
as code owners
pbirkhol-ni
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds
Unused Codecheck to the VI Analyzer workflow.Why should this Pull Request be merged?
Unused Codeis considered a ranking-2 (high-severity) check in VIAnalyzer by default, as having unused code risks performance issues and is exemplary of poor programming practice.Note: Enabling this
Unused Codecheck revealed that certain subVIs proto-generated by grpc-labview are subject to fail the check. To work around this, several exclusions have been added to the VI Analyzer configuration file.What testing has been done?
VI Analyzer tests pass locally and in PR workflow