Handle PR feedback.

ni · Oct 18, 2024 · b1ef8ee · b1ef8ee
1 parent 6d326b0
commit b1ef8ee
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 5 deletions.
diff --git a/packages/nimble-components/src/anchor-tab/template.ts b/packages/nimble-components/src/anchor-tab/template.ts
@@ -10,7 +10,7 @@ export const template: FoundationElementTemplate<
 ViewTemplate<AnchorTab>,
 TabOptions
 > = (context, definition) => html<AnchorTab>`
-    <template slot="tab" role="tab" aria-disabled="${x => x.disabled}">
+    <template slot="anchortab" role="tab" aria-disabled="${x => x.disabled}">
         <a
             download="${x => x.download}"
             href=${x => (x.disabled ? null : x.href)}

diff --git a/packages/nimble-components/src/anchor-tabs/index.ts b/packages/nimble-components/src/anchor-tabs/index.ts
@@ -81,6 +81,11 @@ export class AnchorTabs extends FoundationElement {
      */
     public readonly leftScrollButton!: Element;
 
+    /**
+     * @internal
+     */
+    public readonly tabSlotName = 'anchortab';
+
     private readonly tabListResizeObserver: ResizeObserver;
     private tabIds: string[] = [];
 

diff --git a/packages/nimble-components/src/anchor-tabs/specs/README.md b/packages/nimble-components/src/anchor-tabs/specs/README.md
@@ -57,7 +57,7 @@ We cannot extend FAST's tabs control because it has baked into it the idea that
 -   _CSS Classes and CSS Custom Properties that affect the component_ - None
 -   _Slots_
     -   `start` - content placed to the left of tab list
-    -   `tab` - slot for anchor tab elements
+    -   `anchortab` - slot for anchor tab elements
     -   `end` - content placed to the right of tab list
 
 #### Anchor Tab
@@ -87,7 +87,7 @@ We cannot extend FAST's tabs control because it has baked into it the idea that
 <template>
     <slot name="start"></slot>
     <div role="tablist">
-        <slot name="tab"></slot>
+        <slot name="anchortab"></slot>
     </div>
     <slot name="end"></slot>
 </template>
@@ -96,7 +96,7 @@ We cannot extend FAST's tabs control because it has baked into it the idea that
 #### Anchor Tab
 
 ```html
-<template slot="tab">
+<template slot="anchortab">
     <div role="tab">
         <a>
             <slot></slot>

diff --git a/packages/nimble-components/src/patterns/tabs/template.ts b/packages/nimble-components/src/patterns/tabs/template.ts
@@ -43,7 +43,7 @@ TabsOptions
                 role="tablist"
                 ${ref('tablist')}
             >
-                <slot class="tab" name="tab" part="tab" ${slotted('tabs')}>
+                <slot class="tab" name="${x => x.tabSlotName}" part="tab" ${slotted('tabs')}>
                 </slot>
             </div>
             ${when(x => x.showScrollButtons, html<Tabs>`

diff --git a/packages/nimble-components/src/tabs/index.ts b/packages/nimble-components/src/tabs/index.ts
@@ -33,6 +33,11 @@ export class Tabs extends FoundationTabs {
      */
     public readonly leftScrollButton!: Element;
 
+    /**
+     * @internal
+     */
+    public readonly tabSlotName = 'tab';
+
     private readonly tabListResizeObserver: ResizeObserver;
 
     public constructor() {