Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor package lock files #1953

Merged
merged 26 commits into from
Mar 27, 2024
Merged

Blazor package lock files #1953

merged 26 commits into from
Mar 27, 2024

Conversation

atmgrifter00
Copy link
Contributor

@atmgrifter00 atmgrifter00 commented Mar 20, 2024

Pull Request

🤨 Rationale

👩‍💻 Implementation

Following instructions from MS docs.

See this regarding the addition of DisableImplicitNuGetFallbackFolder to the projects.

🧪 Testing

Verified the pipeline passed with no errors/warnings.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@atmgrifter00 atmgrifter00 linked an issue Mar 20, 2024 that may be closed by this pull request
@msmithNI
Copy link
Contributor

Do we know how these changes will work in conjunction with Renovate updating our .NET dependencies? Do we expect that Renovate will still be able to create PRs for updates (and also handle updating these lock files)?

@atmgrifter00
Copy link
Contributor Author

atmgrifter00 commented Mar 22, 2024

Do we know how these changes will work in conjunction with Renovate updating our .NET dependencies? Do we expect that Renovate will still be able to create PRs for updates (and also handle updating these lock files)?

I can't say that I know. At the very least, when our package.json file is updated with new dependency versions, a re-build of the projects will result in changes to the package lock files as needed. I believe that indicates that things will work as intended with Renovate.

@atmgrifter00 atmgrifter00 marked this pull request as ready for review March 27, 2024 19:09
.github/workflows/main.yml Show resolved Hide resolved
@atmgrifter00 atmgrifter00 enabled auto-merge (squash) March 27, 2024 19:36
@atmgrifter00 atmgrifter00 linked an issue Mar 27, 2024 that may be closed by this pull request
@atmgrifter00 atmgrifter00 merged commit 6e8a7ad into main Mar 27, 2024
13 checks passed
@atmgrifter00 atmgrifter00 deleted the blazor-package-lock-files branch March 27, 2024 19:53
@rajsite rajsite mentioned this pull request Mar 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuget dependencies should be managed with a lockfile
3 participants