Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error text overflow #2432

Merged
merged 10 commits into from
Dec 10, 2024
Merged

Error text overflow #2432

merged 10 commits into from
Dec 10, 2024

Conversation

mollykreis
Copy link
Contributor

@mollykreis mollykreis commented Oct 9, 2024

Pull Request

🀨 Rationale

Fixes #2431

πŸ‘©β€πŸ’» Implementation

Updated the error pattern to be a mixin rather than an interface so that controls using the error pattern don't have to redefine the properties/attributes that the pattern uses. Additionally, logic has been added to the mixin (beyond what the interface supported) to use the overflow behavior to add a title to the error text when it overflows.

πŸ§ͺ Testing

Manually tested in storybook that all updated components:

  • don't have a title on the error text when the error text is short
  • have a title on the error text when the error text overflows
  • the overflow on the error text does not affect any existing overflow behavior on the component

New unit tests for the error pattern mixin

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@m-akinc, will you buddy this PR for me?

@mollykreis mollykreis requested a review from m-akinc October 9, 2024 20:43
@mollykreis mollykreis marked this pull request as ready for review December 9, 2024 17:10
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems relatively straightforward so I'm ok with this going in before @rajsite approves

@mollykreis mollykreis merged commit 2d0ceca into main Dec 10, 2024
12 checks passed
@mollykreis mollykreis deleted the error-text-overflow branch December 10, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error text on components should only have title when content overflows
3 participants