-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error text overflow #2432
Merged
Merged
Error text overflow #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@m-akinc, will you buddy this PR for me? |
m-akinc
approved these changes
Oct 9, 2024
mollykreis
requested review from
rajsite,
jattasNI and
vivinkrishna-ni
as code owners
December 9, 2024 17:10
jattasNI
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems relatively straightforward so I'm ok with this going in before @rajsite approves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Fixes #2431
π©βπ» Implementation
Updated the error pattern to be a mixin rather than an interface so that controls using the error pattern don't have to redefine the properties/attributes that the pattern uses. Additionally, logic has been added to the mixin (beyond what the interface supported) to use the
overflow
behavior to add a title to the error text when it overflows.π§ͺ Testing
Manually tested in storybook that all updated components:
title
on the error text when the error text is shorttitle
on the error text when the error text overflowsNew unit tests for the error pattern mixin
β Checklist