Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Storybook build #2497

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix Storybook build #2497

merged 1 commit into from
Dec 18, 2024

Conversation

fredvisser
Copy link
Contributor

Pull Request

🤨 Rationale

A combination of node 22.12.0 and our Storybook configuration fails. See nodejs/node#56127 for more information.

A quick fix is to remove some unnecessary code that the Storybook migration tools added to our configuration a few releases ago.

👩‍💻 Implementation

  • Removed uses of the getAbsolutePath() macro
  • Removed the @storybook/addon-mdx-gfm Storybook add-on which, per the build logs, isn't necessary to have installed to support GitHub flavored markdown

🧪 Testing

  • Verified that markdown tables still render in Storybook (GFM feature)
  • The build no longer breaks

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated build worked with node 22.7.0 and failed with node 22.12.0 on main.
Validated changes here build with node 22.12.0.

@rajsite rajsite merged commit edf9e9a into main Dec 18, 2024
14 checks passed
@rajsite rajsite deleted the users/fvisser/fix-storybook-build branch December 18, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants