Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

niscope module does not expose calibration info functionality #1463

Closed
marcoskirsch opened this issue May 21, 2020 · 4 comments · Fixed by #1469
Closed

niscope module does not expose calibration info functionality #1463

marcoskirsch opened this issue May 21, 2020 · 4 comments · Fixed by #1469

Comments

@marcoskirsch
Copy link
Member

marcoskirsch commented May 21, 2020

The following functions exist in NI-SCOPE runtime and can be accessed through a regular (not calibration) session. Yet they are not exposed in nimi-python. Equivalent methods are exposed in nimi-python for other driver modules.

When adding to nimi-python, we should make sure they are exposed in a way that is consistent with the other drivers in order to allow duck-typing usage.

NI-SCOPE uses an enum to select between self/external/manufacturing. We probably would be ok exposing self/external only as separate methods like all the other APIs do.

@marcoskirsch
Copy link
Member Author

Related issue: #1462

@marcoskirsch
Copy link
Member Author

Internal Bug 1038236: A customer ran into this issue and needs the cal date functionality exposed.

@shilohbeeler-NI
Copy link
Contributor

shilohbeeler-NI commented May 22, 2020

niScope_CalFetchCount
niScope_CalFetchMiscInfo

Could you point me to an equivalent implementation of either of these two in another module? I'm unable to find any. I've got the other two handled but I don't want to try writing the metadata for these two from scratch unless necessary.

@marcoskirsch
Copy link
Member Author

No other module has anything like niScope_CalFetchCount because none of the other driver runtimes have equivalent functionality as far as I can tell. I am not sure if we should add this to nimi-python – we need to research a bit more. For instance: is this something supported on current modules or only on EOL ones?

niScope_CalFetchMiscInfo is equivalent to:

  • niDCPower_GetCalUserDefinedInfo
  • niDMM_GetCalUserDefinedInfo
  • niFgen_GetCalUserDefinedInfo

Why is NI-SCOPE inconsistent? Great question.
We should expose all four consistently in nimi-python in my opinion because Duck Typing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment