Expose NI-SCOPE calibration functions and make calibration functions consistent for NI-DMM. #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_last_cal_temp to be consistent with the rest of nimi-python.
…mented as get_cal_user_info.
… nidmm and niscope. Fixed the metadata for the functions.
|
Can one of the admins verify this patch? |
|
test this please |
|
Pull Request is fixing multiple issues. As per best practices, we should strive for small bite-sized changes. Can you please split-up the PR. |
Please make this its own PR. Make PRs single-purpose and self-contained as much as it makes sense to. |
|
Also looks like you have merge conflics and failing tests. |
|
Closing PR to investigate issues and separate into single-purpose PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
I've added tests applicable for this pull request
What does this Pull Request accomplish?
Exposed a number of calibration functions in the NI-SCOPE API. Added methods to NI-DMM to make fetching calibration datetime and temperature consistent with other modules. Implemented repr for _RepeatedCapabilities (after much experimenting, it didn't make sense to have repr anywhere else, as best as I could tell).
List issues fixed by this Pull Request below, if any.
nidmm.Session.get_cal_date_and_timeandget_last_cal_tempis different from other nimi-python drivers #1462What testing has been done?
All system tests have been run on the relevant modules and have passed.