Fix for DAQmx input and output tasks #185
Open
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shalini-Subramanian <[email protected]>
Shalini-Subramanian
requested review from
lornazh and
Mattjet27
as code owners
Shalini-Subramanian
requested a deployment
to
gh-action-testing
GitHub Actions
Waiting
|
@lornazh For other drivers, this is already implemented. |
lornazh
reviewed
Dec 25, 2024
| @@ -22,6 +22,7 @@ public static PinSiteData<double[]> ReadAnalogMultiSample(this DAQmxTasksBundle | |||
| return tasksBundle.DoAndReturnPerSitePerPinResults(taskInfo => | |||
| { | |||
| taskInfo.VerifyTaskType(DAQmxTaskType.AnalogInput); | |||
| taskInfo.Task.Stream.ChannelsToRead = taskInfo.ChannelList; | |||
There was a problem hiding this comment.
I think we need to restore original channels after the read operation, otherwise subsequent reads using direct driver calls will be affected.
lornazh
reviewed
Dec 25, 2024
| @@ -19,6 +19,7 @@ public static void WriteAnalogSingleSample(this DAQmxTasksBundle tasksBundle, do | |||
| { | |||
| tasksBundle.Do(taskInfo => | |||
| { | |||
| taskInfo.Task.Stream.ChannelsToRead = taskInfo.ChannelList; | |||
There was a problem hiding this comment.
Analog output channels are used to do write operations. I think we should modify ChannelsToWrite instead.
There was a problem hiding this comment.
I had a check and noticed there is no ChannelsToWrite actually. We use a different mechanism to do the writes, which won't be impacted in similar scenarios.
So nothing needs to be done to Analog/DigitalOutput cs files.
|
Please add unit tests in Analog/DigitalInputTests to verify behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR contains the implementation for updating the channels to be read with the filtered channel list, where the task contain channels for multiple sites for one pin and on applying FilterBySite while we get the measurements.
Why should this Pull Request be merged?
Previously, while getting the measurements for the Daqmx tasks, the channels to be read was not updated with the filtered channel list. This also applies while writing the output tasks as well.
We are updating this logic to read/write channels for the filtered list alone.
What testing has been done?
Read measurements for all sites
Read measurements for filtered sites