Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes android/plaid#616 : Removed Fabric and updated to Firebase Crashlytics #834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thederputy
Copy link

@thederputy thederputy commented Jun 23, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Removed references to fabric crashlytics and replaced with Firebase Crashlytics.

  • Separate versions for the gradle plugin (crashlytics_plugin) and the library dependency (crashlytics)
  • Added maven dependency group for com.google.android.datatransport, which is a transient dependency of Firebase Crashlytics

💡 Motivation and Context

Fabric's Crashlytics is deprecated in favor of Firebase Crashlytics.

Fixes this open issue: #616

💚 How did you test it?

Manually by building and running the app.

📝 Checklist

  • I ran ./gradlew spotlessApply before submitting the PR
  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

Integrate this PR :)

📸 Screenshots / GIFs

…ytics

- Separate versions for the gradle plugin (`crashlytics_plugin`) and the library dependency (`crashlytics`)
- Added maven dependency group for `com.google.android.datatransport`, which is a transient dependency of Firebase Crashlytics
@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants