Add LifetimeTimeout exception

nickspaargaren · Jan 6, 2024 · 0398760 · 0398760
1 parent 52179b5
commit 0398760
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 21 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -43,19 +43,3 @@ jobs:
         run: |
           cd scripts
           python3 tests.py --type regex
-  dns-check:
-    name: Checking dns response for domains
-    runs-on: ubuntu-latest
-    continue-on-error: true
-    steps:
-      - uses: actions/checkout@v2
-        name: Python setup
-      - uses: actions/setup-python@v2
-        with:
-          python-version: 3.8
-      - name: Install pytest
-        run: pip install pytest
-      - name: Check if list includes domains without dns response
-        run: |
-          cd scripts
-          python3 dnscheck.py
diff --git a/scripts/dnscheck.py b/scripts/dnscheck.py
@@ -7,11 +7,12 @@ def check_domain(domain):
         if answer.qname:
             return True
         return False
-    except dns.resolver.NoAnswer:
-        return False
-    except dns.resolver.NoNameservers:
-        return False
-    except dns.resolver.NXDOMAIN:
+    except (
+        dns.resolver.NoAnswer,
+        dns.resolver.NXDOMAIN,
+        dns.resolver.NoNameservers,
+        dns.resolver.LifetimeTimeout,
+    ):
         return False