Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger controller override calculation when zone current temperature changes #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lievendf
Copy link

Tested by warming up the temperature sensor, verified override changes in debug logging.
Not 100% sure about the isinstance check copied from if statement above, but it seems to work...

… changes

Not 100% sure about the isinstance check copied from if statement above
@nielsfaber
Copy link
Owner

Thanks for your PR.

I think we should discuss a little bit more how this improvement should work.
As mentioned in your question thread I have some concerns which don't seem to be considered in your implementation:

However, it should be prevented that in every step of temperature change this updating occurs.
Most TRVs have 0.1C resolution, so recalculating on every step would cause a lot of commands being sent to the thermostat.
In addition, this integration can support multiple zones, so any temperature change in any zone could trigger recalculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants