forked from mrpowers-io/quinn
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Spark-Connect Tests & Update the Documentation #8
Merged
nijanthanvijayakumar
merged 24 commits into
planning-1.0-release
from
feature/issue-241-integrate-sc-tests
Aug 10, 2024
Merged
Integrate Spark-Connect Tests & Update the Documentation #8
nijanthanvijayakumar
merged 24 commits into
planning-1.0-release
from
feature/issue-241-integrate-sc-tests
Aug 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply hotfix update lock file
Align ruff versions and apply hotfix
update makefile add make command for ruff
Improve pre-commit hooks and use of ruff
… GitHub Actions local setup
…rk-Connect <3.5.2
This was included to perform the GH Actions on the feature/ branches to speed up the development & test when working on the Spark-Connect tests upgrade.
Repository owner
locked as off-topic and limited conversation to collaborators
Aug 6, 2024
nijanthanvijayakumar
changed the title
Feature/issue 241 integrate sc tests
Integrate Spark-Connect Tests & Update the Documentation
Aug 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updates to the ci.yml:
Invoke the tests using Spark-Connect & make
Updates to the CONTRIBUTING.md document.
Brings the changes in from the
main
branch describing thepre-commit
installation & setup, and auto-assigning the issues.Refactor the following
*.py
files to work with the Spark-Connect tests and also update the tests accordinglya) dataframe_helpers.py
b) functions.py
c) transformations.py
d) test_functions.py
e) test_transformations.py
[Highlight]: Handling unsupported functions on Spark-Connect less than 3.5.2
a) The functions
array_choice
and thesort_columns
don't work properly on the Spark-Connect v3.5.2 and below. So, raising an exception if the Spark version is < 3.5.2 and ifSPARK_CONNECT_MODE
is enabled.b) Create a wrapper within the
test_transformations.py
, as thesort_columns
function/method is being used widely across 10+ test cases. Using a wrapper would help reduce the duplicate lines of code.Types of changes
What types of changes does your code introduce to Quinn?
Put an
x
in the boxes that applyFurther comments
N/A