Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Spark-Connect Tests & Update the Documentation #8

Merged

Conversation

nijanthanvijayakumar
Copy link
Owner

Proposed changes

  1. Updates to the ci.yml:
    Invoke the tests using Spark-Connect & make

  2. Updates to the CONTRIBUTING.md document.
    Brings the changes in from the main branch describing the pre-commit installation & setup, and auto-assigning the issues.

  3. Refactor the following *.py files to work with the Spark-Connect tests and also update the tests accordingly
    a) dataframe_helpers.py
    b) functions.py
    c) transformations.py
    d) test_functions.py
    e) test_transformations.py

  4. [Highlight]: Handling unsupported functions on Spark-Connect less than 3.5.2
    a) The functions array_choice and the sort_columns don't work properly on the Spark-Connect v3.5.2 and below. So, raising an exception if the Spark version is < 3.5.2 and if SPARK_CONNECT_MODE is enabled.
    b) Create a wrapper within the test_transformations.py, as the sort_columns function/method is being used widely across 10+ test cases. Using a wrapper would help reduce the duplicate lines of code.

Types of changes

What types of changes does your code introduce to Quinn?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

N/A

fpgmaas and others added 20 commits July 15, 2024 13:14
apply hotfix

update lock file
Align ruff versions and apply hotfix
update makefile

add make command for ruff
Improve pre-commit hooks and use of ruff
This was included to perform the GH Actions on the feature/ branches to speed up the development & test when working on the Spark-Connect tests upgrade.
@nijanthanvijayakumar nijanthanvijayakumar self-assigned this Aug 6, 2024
Repository owner locked as off-topic and limited conversation to collaborators Aug 6, 2024
@nijanthanvijayakumar nijanthanvijayakumar changed the title Feature/issue 241 integrate sc tests Integrate Spark-Connect Tests & Update the Documentation Aug 10, 2024
@nijanthanvijayakumar nijanthanvijayakumar merged commit b795b09 into planning-1.0-release Aug 10, 2024
5 checks passed
@nijanthanvijayakumar nijanthanvijayakumar deleted the feature/issue-241-integrate-sc-tests branch August 10, 2024 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants