New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle octet-stream for passthru and credentials in Reqest X-Headers #67

Open

igorvoltaic wants to merge 1 commit into nikepan:master from igorvoltaic:dev

igorvoltaic commented Jul 19, 2023

Move config to global variable to let access it from any app scope
Use stream to handle bytes properly jdbc driver fails to connect Clickhouse without this feature. To reproduce this bug try to connect Click via Bulk with DBreaver
Handle creds in X-ClickHouse-* headers (borrowed this part from chproxy)

Issues left with these changes (and before them):

if any part got dumped and service restated and do not receive any requests after the restart there is no way to resume dumped inserts, since service won't have creds stored. An options is to provide creds thru env var.
RowBinary inserts from dump fail at at some point due to string conversions while being parsed which leads to response: Code: 33. DB::Exception: Cannot read all data. Bytes read: 423943. Bytes expected: 12213357.: (at row 215)


          Handle octet-stream for passthru and credentials in Reqest X-Headers

3260b44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet