Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: object creation only once #15

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix: object creation only once #15

merged 1 commit into from
Apr 3, 2023

Conversation

Ananya2001-an
Copy link
Contributor

In all test files we are creating class objects only once.

@Ananya2001-an
Copy link
Contributor Author

Hey @chrstnbwnkl I was running the tests and this time weirdly the ors test was failing due to a timeout. Though after reverting my changes it was still failing meaning they weren't the problem. But still just test it once from your side.

@nilsnolde
Copy link
Owner

the ors test was failing due to a timeout

That rings a bell no? Wasn't that the case before? Or maybe we just didn't care too much and merged before despite ORS failing?

@chrstnbwnkl
Copy link
Collaborator

@nilsnolde It does ring a bell: nilsnolde/routingpy#85

But for me, the ORS tests here seem to be working for me locally.

@Ananya2001-an
Copy link
Contributor Author

the ors test was failing due to a timeout

That rings a bell no? Wasn't that the case before? Or maybe we just didn't care too much and merged before despite ORS failing?

Earlier when I tested it passed every time but now it started behaving weirdly. Is it because of some network issue?

Copy link
Collaborator

@chrstnbwnkl chrstnbwnkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legitimate, thanks!

@chrstnbwnkl chrstnbwnkl merged commit 752dd7f into main Apr 3, 2023
@chrstnbwnkl chrstnbwnkl deleted the fix-object-creation branch April 3, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants