-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obfuscate private key password in logs #334
Conversation
Hm... the upgrade suite fails. I'll look into that later, it is probably because 2.1 is now the current version or something :\ |
Sounds good. |
428ffdf
to
720a701
Compare
I rebased this PR on #338, and the test pass now for all OTP versions except 25-rc3, where it fails in connection with SSL all over the place. Regardless of this PR, I think this is something that needs to be investigated soon as OTP 25 is just around the corner. |
Where do you see SSL problems? Looking at the Arch Linux logs for example the problem is that Relx is not compatible with OTP 25 and I have fixed that in an Erlang.mk branch (for now) and have patches locally for Ranch and Cowboy. So don't worry about it I will merge all that in order when OTP 25 is released. |
In Ubuntu, MacOS, Debian, Alpine. All tests there pass, until they get to 25-rc3, where 9 in the acceptors suite and 6 in the proxy header suite fail like this:
|
I see. It has to do with certificate verification on the client side. Probably doesn't like the self-signed certificate. Not sure why it wouldn't fail on Arch Linux. |
Hello! Please rebase and let's ignore the expected macOS failure for now. |
720a701
to
a02378c
Compare
Sorry, this totally fell between the cracks XD Rebased. |
Looks like the buildkite CI is down? |
Welp. But I have a complimentary account. Might be a good time to move to Actions instead of BuildKite. |
There's some flaky tests it seems but master is using Actions now, so please rebase so your PR can go through CI. Thanks! |
a02378c
to
3b3da35
Compare
Done. In 26.1.2 on MacOS the upgrade suite fails, but I don't know what the problem could be. Timeout in |
I think it's a flake I've seen it while preparing actions. |
Merged, thanks! |
Closes #333