Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obfuscate private key password in logs #334

Closed
wants to merge 1 commit into from

Conversation

juhlig
Copy link
Contributor

@juhlig juhlig commented Dec 7, 2021

Closes #333

@juhlig
Copy link
Contributor Author

juhlig commented Dec 7, 2021

Hm... the upgrade suite fails. I'll look into that later, it is probably because 2.1 is now the current version or something :\

@essen
Copy link
Member

essen commented Dec 7, 2021

Sounds good.

@juhlig juhlig force-pushed the remove_password_from_logs branch from 428ffdf to 720a701 Compare May 12, 2022 12:20
@juhlig
Copy link
Contributor Author

juhlig commented May 12, 2022

I rebased this PR on #338, and the test pass now for all OTP versions except 25-rc3, where it fails in connection with SSL all over the place. Regardless of this PR, I think this is something that needs to be investigated soon as OTP 25 is just around the corner.

@essen
Copy link
Member

essen commented May 12, 2022

Where do you see SSL problems? Looking at the Arch Linux logs for example the problem is that Relx is not compatible with OTP 25 and I have fixed that in an Erlang.mk branch (for now) and have patches locally for Ranch and Cowboy. So don't worry about it I will merge all that in order when OTP 25 is released.

@juhlig
Copy link
Contributor Author

juhlig commented May 12, 2022

Where do you see SSL problems?

In Ubuntu, MacOS, Debian, Alpine. All tests there pass, until they get to 25-rc3, where 9 in the acceptors suite and 6 in the proxy header suite fail like this:

{error, {tls_alert, {handshake_failure, "TLS client: In state hello received SERVER ALERT: Fatal - Handshake Failure\n"}}}

@essen
Copy link
Member

essen commented May 12, 2022

I see. It has to do with certificate verification on the client side. Probably doesn't like the self-signed certificate. Not sure why it wouldn't fail on Arch Linux.

@essen
Copy link
Member

essen commented May 2, 2023

Hello! Please rebase and let's ignore the expected macOS failure for now.

@juhlig
Copy link
Contributor Author

juhlig commented Oct 17, 2023

Sorry, this totally fell between the cracks XD Rebased.

@juhlig
Copy link
Contributor Author

juhlig commented Oct 19, 2023

Looks like the buildkite CI is down?

@essen
Copy link
Member

essen commented Oct 19, 2023

You've used all of the job minutes included in your Free plan for this month. To continue running your builds, select a different Buildkite plan.

Welp. But I have a complimentary account.

Might be a good time to move to Actions instead of BuildKite.

@essen essen added this to the 2.2 milestone Nov 23, 2023
@essen
Copy link
Member

essen commented Dec 5, 2023

There's some flaky tests it seems but master is using Actions now, so please rebase so your PR can go through CI. Thanks!

@juhlig
Copy link
Contributor Author

juhlig commented Dec 6, 2023

Done. In 26.1.2 on MacOS the upgrade suite fails, but I don't know what the problem could be. Timeout in os:get_data it says, seems unrelated to this PR.

@essen
Copy link
Member

essen commented Dec 6, 2023

I think it's a flake I've seen it while preparing actions.

@essen
Copy link
Member

essen commented Dec 6, 2023

Merged, thanks!

@essen essen closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password should be blanked instead of logged on error
2 participants