Skip to content

Commit

Permalink
Don't double-count the 'node stat' metric.
Browse files Browse the repository at this point in the history
This is already done in RealDiskInterface::Stat() itself,
and removes a confusing duplicate line in `-d stats` output,
e.g.:

BEFORE:
  metric                  count   avg (us)        total (ms)
  ...
  node stat               119145  3.0             355.2
  node stat               270673  3.1             834.9

AFTER:
  metric                  count   avg (us)        total (ms)
  ...
  node stat               270673  2.9             774.0
  • Loading branch information
digit-android authored and digit-google committed Apr 27, 2023
1 parent b5ef3c5 commit 5cf581e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/graph.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
using namespace std;

bool Node::Stat(DiskInterface* disk_interface, string* err) {
METRIC_RECORD("node stat");
mtime_ = disk_interface->Stat(path_, err);
if (mtime_ == -1) {
return false;
Expand Down

0 comments on commit 5cf581e

Please sign in to comment.