Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining time estimate to Ninja status. #1602

Closed
wants to merge 1 commit into from

Conversation

jpakkane
Copy link

Creates a new token %h (for "human readable", more suitable letters were already taken) that displays an estimate on how long the current build will last.

It's meant to be informative rather than accurate. When there is a lot of time remaining it will look like this:

1h 15m

and when there is only a small amount of work left it looks like this:

53s

@jonesmz

This comment was marked as abuse.

@jpakkane
Copy link
Author

jpakkane commented Aug 2, 2019

Does this pull request address historical data from previous builds?

No.

which I don't think is accurate at all.

This MR is not meant to be to be super accurate. It is to give a rough estimate to the user. Simply getting to know whether the build will take 5 seconds, a minute, 5 minutes or 30 minutes is useful on its own. It is better than having no estimates at all, which is the current situation.

Better would be to offer no estimate at all for the first build, and then subsequently offer estimates based on how long each task has taken in the past

That can be done but it will take a lot more code. Doing it right takes on the order of hundreds of lines of code whereas this MR is around 20. Also the exact estimation algorithm can be changed later so if someone wants to improve the accuracy, they can do that later in a separate merge request.

@jonesmz

This comment was marked as abuse.

@jonesmz

This comment was marked as abuse.

@jhasse
Copy link
Collaborator

jhasse commented Apr 29, 2021

Closing in favor of #1963.

@jhasse jhasse closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants