Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'dupbuild' as deprecated warning #2483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dendy
Copy link

@dendy dendy commented Aug 28, 2024

Fixup after 8f47d5a

Since v1.12 ninja breaks compatibility with existing generators, particularly bob build system, which always invokes ninja with -w dupbuild=err

See: https://github.com/ARM-software/bob-build/blob/master/bob.bash

This patch should also be applied to the 'release' branch.

@tsniatowski
Copy link

This would be nice to have, I think it's unfortunate that #2356 causes a hard breakage for people that were already opting-in to the warning.

@digit-google
Copy link
Contributor

Thank you, this looks good to me, the macOS build failures are unrelated to this PR, and hopefully will be addressed shortly.

@digit-google
Copy link
Contributor

PR #2479 was submitted to fix the MacOS issue, please rebase on top of current origin/master and re-upload to get the checks to pass.

Fixup after 8f47d5a

Since v1.12 ninja breaks compatibility with existing generators,
particularly bob build system, which always invokes ninja with
-w dupbuild=err

See: https://github.com/ARM-software/bob-build/blob/master/bob.bash

This patch should also be applied to the 'release' branch.
@dendy dendy force-pushed the add-dupbuild-as-deprecated-warning branch from dc1935d to a91a30e Compare August 28, 2024 13:51
@dendy
Copy link
Author

dendy commented Aug 28, 2024

Rebased, all tests passed.

@mcprat
Copy link
Contributor

mcprat commented Aug 29, 2024

commit message doesn't need the last line about backporting

and if you want to be very formal See: can be replaced with Link:

@dendy
Copy link
Author

dendy commented Aug 29, 2024

commit message doesn't need the last line about backporting

Agree, was hesitating about that, but decided to add that line for better visibility. Will remove.

and if you want to be very formal See: can be replaced with Link:

Don't want to be over formal, unless there are strict rules. Any reason to prepend "Link:", isn't it obvious that link is a link? :-) I know people who have a habit to always begin commit body with "Description:" which is silly.

@mcprat
Copy link
Contributor

mcprat commented Aug 29, 2024

I agree that is silly... I just mentioned Link: because that's de-facto linux standard tagging and makes it greppable

@jhasse jhasse added this to the 1.12.2 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants