-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'dupbuild' as deprecated warning #2483
base: master
Are you sure you want to change the base?
Conversation
This would be nice to have, I think it's unfortunate that #2356 causes a hard breakage for people that were already opting-in to the warning. |
Thank you, this looks good to me, the macOS build failures are unrelated to this PR, and hopefully will be addressed shortly. |
PR #2479 was submitted to fix the MacOS issue, please rebase on top of current |
Fixup after 8f47d5a Since v1.12 ninja breaks compatibility with existing generators, particularly bob build system, which always invokes ninja with -w dupbuild=err See: https://github.com/ARM-software/bob-build/blob/master/bob.bash This patch should also be applied to the 'release' branch.
dc1935d
to
a91a30e
Compare
Rebased, all tests passed. |
commit message doesn't need the last line about backporting and if you want to be very formal |
Agree, was hesitating about that, but decided to add that line for better visibility. Will remove.
Don't want to be over formal, unless there are strict rules. Any reason to prepend "Link:", isn't it obvious that link is a link? :-) I know people who have a habit to always begin commit body with "Description:" which is silly. |
I agree that is silly... I just mentioned |
Fixup after 8f47d5a
Since v1.12 ninja breaks compatibility with existing generators, particularly bob build system, which always invokes ninja with -w dupbuild=err
See: https://github.com/ARM-software/bob-build/blob/master/bob.bash
This patch should also be applied to the 'release' branch.