Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inputs tool logic and add new formatting options. #2485

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Fix inputs tool logic and add new formatting options. #2485

merged 3 commits into from
Sep 19, 2024

Commits on Sep 2, 2024

  1. Add InputsCollector class. 

    Add a new class to wrap the logic needed to implement the
`inputs` tool correctly (see Issue ninja-build#2482 for details), and
provide a unit-test for it.
    @digit-google
    digit-google committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7e03348 View commit details
    Browse the repository at this point in the history

  2. Fix inputs tool implementation. 

    This uses the InputsCollector class introduced in the
previous patch to implement the tool properly. Results
are still shell-escaped and sorted alphabetically.

Fixed ninja-build#2482
    @digit-google
    digit-google committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5b94d34 View commit details
    Browse the repository at this point in the history

  3. Add new options to inputs tool. 

    Add new options to the `inputs` tool in order to change
the format of its output:

- `--no-shell-escape` to avoid shell-escaping the results.

- `--dependency-order` to return results in dependency order,
  instead of sorting them alphabetically.

- `--print0` to use \0 as the list separator in the list,
  useful to process the target paths with `xargs -0` and
  similar tools.
    @digit-google
    digit-google committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2843493 View commit details
    Browse the repository at this point in the history