Ensure depfile's parent directory is created before running an action. #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most actions, the depfile will be in the same directory as one of its outputs, and their parent directory will be created by Ninja before running the command. However, this is not always the case. In particular, the GN build tool is changing its Ninja build plan generation logic, switching from using stamp files to phony targets, after issue ninja-build#478 was fixed in Ninja. For additionnal context see https://gn-review.googlesource.com/c/gn/+/11380. The newly generated build plans trigger this condition more frequently, which results in flaky build failures for large GN-based projects such as Fuchsia. This patch ensures the depfile's parent directory is always created before the command is launched to get rid of the issue entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most actions, the depfile will be in the same directory as one of its outputs, and their parent directory will be created by Ninja before running the command. However, this is not always the case.
In particular, the GN build tool is changing its Ninja build plan generation logic, switching from using stamp files to phony targets, after issue #478 was fixed in Ninja. For additionnal context see https://gn-review.googlesource.com/c/gn/+/11380.
The newly generated build plans trigger this condition more frequently, which results in flaky build failures for large GN-based projects such as Fuchsia.
This patch ensures the depfile's parent directory is always created before the command is launched to get rid of the issue entirely.