Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc/ci.py: Ignore src/third_party directory. #2522

Conversation

digit-google
Copy link
Contributor

This is necessary to be able to use third-party code that contains trailing spaces and other oddities.

See PR #2519 for context.

This is necessary to be able to use third-party code that
contains trailing spaces and other oddities.

See PR ninja-build#2519 for context.
@digit-google digit-google mentioned this pull request Nov 4, 2024
@jhasse
Copy link
Collaborator

jhasse commented Nov 5, 2024

Use the ignores array above instead :)

I also think this should be part of the PR that adds the directory, on its own it doesn't make any sense.

@jhasse jhasse closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants