Fix build log leak #2534
Merged
Fix build log leak #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The erase() call to remove `dead_outputs` was leaking the LogEntry value that the map pointed to. This patch changes the type of `Entries` to store `std::unique_ptr<LogEntry>` values, instead of raw pointers to get rid of the problem, and adjust call sites accordingly. Also use Entries::emplace() instead of Entries::insert() to create the new value in-place when inserting new ones into the map.
digit-google
force-pushed
the
fix-build-log-leak
branch
from
e7ebebc to
3ecea33
Compare
|
In general I'm against cleanup changes (i.e. adding Thanks :) |
|
I understand :-) That's one of the reasons why I decomposed this into a series of small commits, apart from making reviews easier, it minimizes the chances of conflicts, or make them much easier to resolve in practice. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a memory leak in BuildLog::Recompact(), when calling
entries_.erase()for dead outputs would not free the pointed-to LogEntry.Rather than doing a local fix with an expliciti delete, this changes the
Entriestype to usestd::unique_ptr<LogEntry>values instead of raw pointers, as this will prevent similar bugs to appear in the future. Other call sites are updated appropriately.This also contains minor cleanups in separate commits:
build_log.h.using namespace stdfrombuild_log.ccandbuild_log_test.cc