Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /utf-8 compiler option to fix MSVC C4819 warning. #2537

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

zufuliu
Copy link
Contributor

@zufuliu zufuliu commented Nov 30, 2024

https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4819?view=msvc-170

The file contains a character that cannot be represented in the current code page (number). Save the file in Unicode format to prevent data loss.

https://learn.microsoft.com/en-us/cpp/build/reference/utf-8-set-source-and-executable-character-sets-to-utf-8?view=msvc-170

Specifies both the source character set and the execution character set as UTF-8.

PR #1915 added UTF-8 manifest, I think use /utf-8 would be a nature fix for C4819 warning (on src/depfile_parser.cc), instead of just suppress it.

cc @jhasse

@jhasse jhasse merged commit d79d8f7 into ninja-build:master Dec 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants