Add default virtual destructor for Parser class.
#2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I think it would make more sense to add a virtual (default) destructor to the Parser base class instead. Can you do that? |
This fixed clang `[-Wdelete-non-abstract-non-virtual-dtor]` warning:
delete called on non-final 'ManifestParser' that has virtual
functions but non-virtual destructor.
for `subparser_.reset(new ManifestParser(state_, file_reader_, options_));`.
zufuliu
force-pushed
the
fix-clang-Wdelete-non-abstract-non-virtual-dtor
branch
from
5be431f to
32e9958
Compare
zufuliu
changed the title
ManifestParser class as final.Parser class.
zufuliu
changed the title
Parser class.Parser class.
|
Thanks, this looks good to me. @jhasse , wdyt? |
|
thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed clang
[-Wdelete-non-abstract-non-virtual-dtor]warning:delete called on non-final 'ManifestParser' that has virtual
functions but non-virtual destructor.
for
subparser_.reset(new ManifestParser(state_, file_reader_, options_));.