Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Minor refactor reorganizing base workflows, in prep for #97 #110

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Jun 2, 2020

Just to make the diff of #97 a bit cleaner.

@pull-assistant
Copy link

pull-assistant bot commented Jun 2, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     enh: minor refactor reorganizing base workflows, in prep for #97

Powered by Pull Assistant. Last update 83f6ed1 ... 83f6ed1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #110 into master will decrease coverage by 0.55%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   51.92%   51.37%   -0.56%     
==========================================
  Files          20       20              
  Lines        1221     1238      +17     
  Branches      161      162       +1     
==========================================
+ Hits          634      636       +2     
- Misses        575      590      +15     
  Partials       12       12              
Impacted Files Coverage Δ
dmriprep/workflows/dwi/base.py 47.05% <ø> (+2.61%) ⬆️
dmriprep/workflows/dwi/util.py 21.15% <11.76%> (-3.85%) ⬇️
dmriprep/workflows/base.py 22.35% <25.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a20ba...83f6ed1. Read the comment docs.

@oesteban oesteban merged commit 6792e96 into nipreps:master Jun 2, 2020
@oesteban oesteban deleted the maint/refactor-individual-runs branch June 2, 2020 18:39
Copy link
Collaborator

@josephmje josephmje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oesteban . This looks good to me! I had a question about the _normalize() function. Is it meant to remove negative values in the data or simply fix the range of intensity values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants