Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging updates from R. Zinke and A. Borsa #58

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

katia-tymofyeyeva
Copy link
Contributor

Number of major updates: cosmetic, structural, and related to methods for pre-processing GNSS data. Full descriptions in corresponding commits.

rzinke and others added 2 commits August 7, 2024 23:13
a) for testing purposes, added a small-volume site (“TEST") over Mojave in early 2019

1.). SES_Environments.ipynb

This notebook should now be run in its entirety when a users sets up a new solid_earth_atbd environment or wants to refresh their current environment.

a) removed all code not related to Solid Earth
b) reordered and renamed workflow steps
c) added missing netrc class definition to Authentication section

2.). ARIA_prep.ipynb

a) table of contents moved to top
b) Environment Setup reordered/refactored in standard format
c) other stylistic changes for consistency across notebooks

3.) Secular_Requirement_Validation.ipynb

a) added minty.objects.coord line to Load Python Packages
b) moved tropospheric correction link/comment into markdown text [Section 3.2]
c) added code to read Incident/Azimuth angles from geometryGeo.h5 [Section 4.2]
d) fixed deprecated code [Section 4.4]: gnss_count = int(gnss_count[0][0])
e) removed unnecesary counter variable in Section 4.4
f) added line to print out reference station in Section 4.6
g) changed "validation approach” to “validation method”
h) removed redundant MintPy velocity plots in two places
i) other stylistic changes for consistency across notebooks
@katia-tymofyeyeva katia-tymofyeyeva self-assigned this Sep 5, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@EJFielding EJFielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I would only suggest uploading the notebooks with the outputs removed. We found that worked better to avoid git detecting changes that are only output.

@katia-tymofyeyeva katia-tymofyeyeva merged commit 05448e7 into main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants