Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNSS source and outlier removal updates pt2 #59

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

rzinke
Copy link
Contributor

@rzinke rzinke commented Sep 7, 2024

.~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.
ARIA_prep.ipynb
1.1 Download GUNW Interferograms

  • Added "" around password to escape special characters

.~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.
Secular_Requirement_Validation.ipynb
3.2 Tropospheric Delay Correction

  • Added statement to read my_sites file for tropo flag

4.1 Estimate InSAR LOS Velocities

  • Added sentences to end of text block describing the basis functions to be solved for, and that those same functions will be applied to both InSAR and GNSS datasets
  • Added cell defining basis functions
  • Changed MintPy call to solve for linear fits using user-defined basis functions
  • Added plot of linear velocity for user reference (was this removed intentionally?)

4.3 Find Collocated GNSS Stations

  • fixed typo, clarified text, and specified GNSS source options
  • Added statement to read my_sites file for GNSS argument
  • gnss_source now passed to search_gnss function

4.4 Get GNSS Position Time Series

  • gnss_source now passed to get_gnss_class function

4.5 Estimate GNSS LOS Velocities

  • Added functions for iteratively removing outliers and estimating standard errors

A.4 GNSS Timeseries Plots

  • gnss_source now passed to get_gnss_class

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Sep 7, 2024

View / edit / reply to this conversation on ReviewNB

EJFielding commented on 2024-09-07T14:44:36Z
----------------------------------------------------------------

The new table output and plots look great!


Copy link

review-notebook-app bot commented Sep 7, 2024

View / edit / reply to this conversation on ReviewNB

EJFielding commented on 2024-09-07T14:44:37Z
----------------------------------------------------------------

Line #145.    gnss_velocities = []

I would recommend breaking this into a separate cell here. It is hard to see where the beginning of the regular code starts after the long set of function definitions.


Copy link

review-notebook-app bot commented Sep 7, 2024

View / edit / reply to this conversation on ReviewNB

EJFielding commented on 2024-09-07T14:44:38Z
----------------------------------------------------------------

Can this set of plots be changed to use the GNSS data after the outliers were removed?


Copy link
Collaborator

@EJFielding EJFielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions with ReviewNB for two small adjustments, but I am approving it as-is to get it merged now.

@EJFielding EJFielding merged commit 2cba73d into main Sep 7, 2024
1 check passed
katia-tymofyeyeva added a commit that referenced this pull request Sep 9, 2024
* GNSS source and outlier removal updates (#59)

Co-authored-by: rzinke <[email protected]>

* GNSS functions to gnss_utils and reuse filtered gnss data (#60)

Co-authored-by: rzinke <[email protected]>

---------

Co-authored-by: rzinke <[email protected]>
Co-authored-by: rzinke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants