Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/nixos/common/update: switch to apply script, refactor #1562

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 11, 2024

No description provided.

@@ -6,25 +6,36 @@ if [[ "$(readlink /run/current-system)" == "$p" ]]; then
exit 0
fi

nix-store --option narinfo-cache-negative-ttl 0 --realise "$p"
nix-env --profile /nix/var/nix/profiles/system --set "$p"
nix-store \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to add this code eventually to buildbot-nix in its current form (also with support for both macos & NixOS).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macos support is complicated, nix-darwin doesn't have something like restartIfChanged for services and there isn't a way of monitoring failed services like we have on linux. I was planning to just keep using push deployments for darwin but switching from actions to effects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to come up with a common interface for both? Otherwise deploy tools all have to take care of those differences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understand what a "common interface" means here if it isn't a deployment tool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants