Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit testing via BATS #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

erikvip
Copy link

@erikvip erikvip commented Jun 4, 2016

I'm making some fixes / enhancements to optparse & created a basic test suite using BATS to ensure everything is working. Would be nice to get this all into master ...

Usage and general process notes are documented in CONTRIBUTORS.md.

It's real easy to use:

  • Install bats (On Ubuntu it's in apt)
    • apt-get install bats
  • From project root, run bats tests/

Two of the tests will fail, as they're testing for #15 and #17. Everything else should be passing.

I hope this will help spark some more development on optparse. It's a cool little utility, I like it.

If not, I'm gonna fork to erikvip/optparse2 and get all my fixes & the community fixes merged into one branch.

Thanks

…ation for contributors about running tests.

Adds unit testing with 12 tests. 2 of which will be failing on the upstream nk412/optparse master, but this will be addressed in seprate pull requests.
See documentation under CONTRIBUTORS.md. Simple tests use a wrapper and go in tests/optparse.run.bats, while more advanced testing is in tests/optparse.load.bats.

Added a testcase for bash's nounset option, which will 'exit 1' when encountering an undefined variable. Optparse1 does not handle nounset properly

Added testcase for default values with spaces and special character

Added list of current known issues

Moved run tests to optparse.run.bats, to reflect this scripts use RUN and not LOAD for testing

Added bats load tests, which include optparse directly and build options in each test case, for more advanced test cases

Updated docs for test cases

Doc updates: added general process workflow, additional goals / features, fixed typo
…uest. Moved the nounset test to bottom, and removed default value with spaces, which are addressed in seperate pull requests. We still fail 2 tests at the end, but that's normal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant