Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Pico 2.0 #15

Merged
merged 4 commits into from
Nov 14, 2017
Merged

Fix for Pico 2.0 #15

merged 4 commits into from
Nov 14, 2017

Conversation

jheimbach
Copy link
Contributor

While I was on it, i fixed your Plugin for Pico 2.0.
parameters for onPageRendering changed, that's all what i think is changed.

@nliautaud
Copy link
Owner

Oh great, thanks !
There is a 2.0 branch (see #10), could you edit the PR to point to this one ?

@jheimbach jheimbach changed the base branch from master to pico-2.0 November 14, 2017 13:41
@jheimbach
Copy link
Contributor Author

sorry, didnt saw the other branch, changed the base to pico-2.0

@nliautaud nliautaud merged commit 6634c43 into nliautaud:pico-2.0 Nov 14, 2017
@nliautaud
Copy link
Owner

Great, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants