fix: set a maximum number of threads #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation According to the `solrwayback` team, the maximum number of threads that can be safely used for indexing is 40. This assumes that the filesystem uses SSDs to store the data. According to them, more threads will result in errors and not a slowdown. If slower storage media is used, the number of threads should be reduced. # Interface If you give too many or too few threads, you will get the following output: ``` python index_it.py --collection t --warc-file-directory /warc-collection/ --number-of-threads 41 usage: index_it.py [-h] --collection COLLECTION --warc-file-directory WARC_FILE_DIRECTORY --number-of-threads NUMBER_OF_THREADS index_it.py: error: argument --number-of-threads: Number of threads must be less than or equal to 40 ``` ``` python index_it.py --collection t --warc-file-directory /warc-collection/ --number-of-threads 0 usage: index_it.py [-h] --collection COLLECTION --warc-file-directory WARC_FILE_DIRECTORY --number-of-threads NUMBER_OF_THREADS index_it.py: error: argument --number-of-threads: Number of threads must be greater than 0 ```
trym-b
force-pushed
the
fix/add-max-threads
branch
from
05f48c6
to
e5d8a8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
According to the
solrwaybackteam, the maximum number of threads that can be safely used for indexing is 40. This assumes that the filesystem uses SSDs to store the data. According to them, more threads will result in errors and not a slowdown.If slower storage media is used, the number of threads should be reduced.
Interface
If you give too many or too few threads, you will get the following output: