Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rho feature for 2DAR documentation #250

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fix rho feature for 2DAR documentation #250

merged 2 commits into from
Sep 18, 2024

Conversation

e-perl-NOAA
Copy link
Collaborator

See issue #249.

  • Advise not to use rho with 2DAR as it's not properly implemented
  • Remove rho parameter lines from example tables

@e-perl-NOAA e-perl-NOAA added bug Something isn't working Manual labels Sep 18, 2024
@github-actions GitHub Actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.html
Please review your changes in the linked artifacts.

@github-actions GitHub Actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

iantaylor-NOAA
iantaylor-NOAA approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e-perl-NOAA, looks good. I thought of a few more minor edits that I just pushed instead of trying to describe in the review. Feel free to modify my changes as you wish.

@github-actions GitHub Actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.html
Please review your changes in the linked artifacts.

@github-actions GitHub Actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

@e-perl-NOAA e-perl-NOAA merged commit 8bbae54 into main Sep 18, 2024
4 checks passed
@e-perl-NOAA e-perl-NOAA deleted the remove-rho-2dar branch September 18, 2024 19:11
@github-actions GitHub Actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.html
Please review your changes in the linked artifacts.

@Rick-Methot-NOAA
Copy link
Collaborator

Thanks. Can we say "not implemented", rather than "incorrectly"

@github-actions GitHub Actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

@e-perl-NOAA e-perl-NOAA restored the remove-rho-2dar branch September 18, 2024 19:32
@e-perl-NOAA e-perl-NOAA deleted the remove-rho-2dar branch September 18, 2024 19:33
e-perl-NOAA added a commit that referenced this pull request Sep 18, 2024
@e-perl-NOAA
Fix rho feature for 2DAR documentation (#250)
a666b92 
* don't use rho; fix tables to remove rho
* minor changes to 2DAR advise

---------

Co-authored-by: Ian Taylor <[email protected]>

Update 9control.tex with "not implemented"
@github-actions GitHub Actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.html
Please review your changes in the linked artifacts.

@github-actions GitHub Actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iantaylor-NOAA iantaylor-NOAA iantaylor-NOAA approved these changes

@Rick-Methot-NOAA Rick-Methot-NOAA Awaiting requested review from Rick-Methot-NOAA

Assignees
No one assigned
Labels
bug Something isn't working Manual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e-perl-NOAA @Rick-Methot-NOAA @iantaylor-NOAA