Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct index usage in expval #488

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

Rick-Methot-NOAA
Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA commented Jul 28, 2023

Concisely describe what has been changed/addressed in the pull request.

What tests have been done?

Where are the relevant files?

A temporary version of vendance seasonal wtatage model was created and a temporary write statement was put into expval. This verified that the error existed. No other usage of Wt_Age_t(y, f) exists in the code. All are now Wt_Age_t(t, f)

What tests/review still need to be done?

None

Is there an input change for users to Stock Synthesis?

Additional information (optional).

@Rick-Methot-NOAA Rick-Methot-NOAA linked an issue Jul 28, 2023 that may be closed by this pull request
@Rick-Methot-NOAA Rick-Methot-NOAA marked this pull request as ready for review July 28, 2023 20:07
Copy link
Contributor

@nschindler-noaa nschindler-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a programming standpoint.

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit d63f29c into main Jul 29, 2023
9 checks passed
@Rick-Methot-NOAA Rick-Methot-NOAA deleted the 484-bug-wtatage_t-using-wrong-index branch July 29, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: empirical wtatage using wrong time index if >1 season
2 participants