Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair_check_on_Nparms_in_parfile #491

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

Rick-Methot-NOAA
Copy link
Collaborator

The checksum value at end of ss.par was intended to provide a check when the number of parameters in the model changed. This check is now added to ss_prelim. SS3 will exit if value of checksum, which is not actually a checksum, is not equal to 999.

No issue is linked
No input change for the user. The 999 value is created when a model is read from the control file.

@Rick-Methot-NOAA Rick-Methot-NOAA marked this pull request as ready for review August 1, 2023 21:36
Copy link
Collaborator

@e-perl-NOAA e-perl-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed number at end of ss.par and got that fatal warning.

@Rick-Methot-NOAA Rick-Methot-NOAA requested review from e-perl-NOAA and removed request for nschindler-noaa August 4, 2023 18:30
@Rick-Methot-NOAA Rick-Methot-NOAA merged commit 1e126bd into main Aug 4, 2023
9 checks passed
@Rick-Methot-NOAA Rick-Methot-NOAA deleted the repair_checksum_parfile branch August 4, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants