fix MSY search output with >1 season #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rick-Methot-NOAA, can you walk me through where these changes are showing up in the report file a bit more? At first glance, the logic seems fine but I'm having a hard time finding where it will show up. @iantaylor-NOAA Maybe you could help me out with this since Rick is at PICES this week? |
|
The output is only in forecast-report.sso and is not used by any R read
functions that I know of. Basically it is just for my investigation of
user problems when they occur.
…On Mon, Oct 23, 2023 at 7:13 AM Elizabeth Gugliotti < ***@***.***> wrote:
@Rick-Methot-NOAA <https://github.com/Rick-Methot-NOAA>, can you walk me
through where these changes are showing up in the report file a bit more?
At first glance, the logic seems fine but I'm having a hard time finding
where it will show up. @iantaylor-NOAA <https://github.com/iantaylor-NOAA>
Maybe you could help me out with this since Rick is at PICES this week?
—
Reply to this email directly, view it on GitHub
<#521 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPV4IFMRHHFZH7K2RJ6JJTYAZ3QJAVCNFSM6AAAAAA6JUFR2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVGI4TSMBYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
e-perl-NOAA
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format of the MSY search output was corrupted when there is >1 season. Fix by using colsum to output the sum of catch across seasons for each fleet.
There is no issue.
What tests have been done?
examined revised output and verified that it was correct to use colsum, not rowsum
Where are the relevant files?
[x] No test files are required for this pull request.