This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Fix error in "Render and update" addin #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes noamross#57 My understanding is that this is a remnant of a pre-refactor form of dedoc() as dedoc() currently does not use this parameter and handles the roundtrip process internally; I tested it without the parameter and it seems to work but will require review to make sure I didn't miss anything.
|
First time tester, this was the immediate error I ran into with This error came up via the addin as well as the console with roundtrip() like |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error occurs because
dedoc()does not take the parameter passed bydedoc_to_active_file(), which thus passes it toword_document().My understanding is that this is a remnant of a pre-refactor form of dedoc() as dedoc() currently does not use this parameter and handles the roundtrip process internally; I tested it without the parameter and it seems to work but will require review to make sure I didn't miss anything.
Fixes #57