Skip to content

Commit

Permalink
(shortfin) Fix dev_me.py: --clang arg and mishandling of a pathlib.Po…
Browse files Browse the repository at this point in the history
…sixPath (#523)
  • Loading branch information
renxida authored Nov 14, 2024
1 parent e9ba3ef commit 4271115
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions shortfin/dev_me.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,10 @@ def find_clang(self, args):
clang_exe = shutil.which("clang")
if not clang_exe:
return None, None
try:
clang_output = subprocess.check_output(
[clang_exe, "--version"]
).decode()
except:
return None, None
try:
clang_output = subprocess.check_output([clang_exe, "--version"]).decode()
except:
return None, None
if m := re.search(r"clang version ([0-9\.]+)", clang_output):
return clang_exe, Version(m.group(1))
return None, None
Expand Down Expand Up @@ -244,7 +242,7 @@ def configure_mode(env_info: EnvInfo, args):
"-e",
str(env_info.this_dir),
]
print(f"{' '.join('='.join(kv) for kv in env_vars.items())} \\")
print(f"{' '.join('='.join(str(kv)) for kv in env_vars.items())} \\")
print(f" {' '.join(setup_args)}")
actual_env_vars = dict(os.environ)
actual_env_vars.update(env_vars)
Expand Down

0 comments on commit 4271115

Please sign in to comment.