Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libshortfin] Add a workflow with disabled GIL #219

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

marbre
Copy link
Collaborator

@marbre marbre commented Sep 26, 2024

This adds a seperate, and therefore temporary, workflow to run with a free-threaded Python which should be embedded into a matrix strategy.

To fully enable testing without the GIL, it is required to declare that _shortfin_default.lib can either be safley run without it or to run with PYTHON_GIL=0.

This adds a seperate, and therefore temporary, workflow to run with a
free-threaded Python which should be embedded into a matrix strategy.

To fully enable testing without the GIL, it is required to declare that
`_shortfin_default.lib` can either be safley run without it or to run with
`PYTHON_GIL=0`.
# See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

name: CI - libshortfin - GIL disabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this something like Python 3.13 Freethreaded

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course :)

@marbre marbre merged commit 2818131 into nod-ai:main Sep 26, 2024
7 of 8 checks passed
@marbre marbre deleted the ci-nogil branch September 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants