[libshortfin] Build fixes for gcc 12.3.0 and 13.2.0. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Sep 26, 2024
Comment on lines
191
to
194
| protected: | ||
| Queue(Options options); | ||
|
|
||
| private: |
There was a problem hiding this comment.
If we want to keep this constructor private, we could also rework the anonymous namespace used for QueueCreator, which is already tagged friend struct QueueCreator.
There was a problem hiding this comment.
Found a different fix: https://stackoverflow.com/a/63398702
Apparently friend struct QueueCreator was an "elaborated type specifier", and that is not needed here since the name is not ambiguous. gcc is happier with just friend QueueCreator.
marbre
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215