[sharktank] Evaluation - Add Perplexity test #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsuderman
approved these changes
Sep 27, 2024
…into perplexity-test
ScottTodd
reviewed
Oct 16, 2024
Comment on lines
+18
to
+21
| llama_8b_f16_gguf_path = "/data/extra/models/llama3.1_8B/llama8b_f16.gguf" | ||
| llama_8b_f16_tokenizer_path = ( | ||
| "/data/extra/models/llama3.1_8B/tokenizer_config.json" | ||
| ) |
There was a problem hiding this comment.
Unit tests failed on this PR and after merge:
- https://github.com/nod-ai/SHARK-Platform/actions/runs/11359973189/job/31596941530
- https://github.com/nod-ai/SHARK-Platform/actions/runs/11360375745/job/31598023494
Any files required to run a test should be either
- included in the repository (if small enough)
- downloaded (and cached) on demand as part of the test
- downloaded (and cached) ahead of time via a script
As this is, this test will only run on a machine that has already run some unknown, undocumented setup steps.
Comment on lines
+59
to
+60
| - name: Run perplexity test | ||
| run: pytest sharktank/tests/evaluate/perplexity_test.py |
There was a problem hiding this comment.
If more tests are going in this category, we could use pytest marks or some other filtering to pick up the list of tests to run. As this is now, the new tests are running in multiple workflows (on every commit and here on a nightly schedule).
| @@ -7,6 +7,7 @@ onnx==1.15.0 | |||
| huggingface-hub==0.22.2 | |||
| transformers==4.40.0 | |||
| sentencepiece==0.2.0 | |||
| datasets==3.0.0 | |||
There was a problem hiding this comment.
We should steer towards putting requirements in the subproject requirements files instead of this top level file, especially if this is a test-only requirement
- Existing requirements file specific to sharktank: https://github.com/nod-ai/SHARK-Platform/blob/main/sharktank/requirements.txt
- Test requirements file for shortfin: https://github.com/nod-ai/SHARK-Platform/blob/main/shortfin/requirements-tests.txt
archana-ramalingam
added a commit
that referenced
this pull request
Oct 16, 2024
This reverts commit e30d0af.
archana-ramalingam
added a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Perplexity test for LLM evaluation