Add python3.12 requirement to README #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the `walk_up` method of PurePath from pathlib that was introduced in python3.12.
ScottTodd
approved these changes
Oct 15, 2024
| @@ -12,6 +12,10 @@ Use this as a guide to get started developing the project using pinned, | |||
| pre-release dependencies. You are welcome to deviate as you see fit, but | |||
| these canonical directions mirror what the CI does. | |||
|
|
|||
| ### Requirements | |||
|
|
|||
| - Python3.12 | |||
There was a problem hiding this comment.
3.13 is also supported as is 3.13t, so I'd put + here
Suggested change
| - Python3.12 | |
| - Python3.12+ |
|
Closing since this is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
walk_upmethod of PurePath from pathlib that was introduced in python3.12.I suppose we could also just implement walk_up() manually so we can support more python versions. Not sure if any other pieces will require 3.12