[sharktank] Add test for sharded rotary table #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be able to validate the sharded rotary table via comparison with the unsharded version. This runs the sharded and unsharded implementations, asserting near identical results.
rsuderman
force-pushed
the
sharded_rotary_test
branch
from
73204d6
to
498aadb
Compare
sogartar
reviewed
Oct 11, 2024
sogartar
approved these changes
Oct 11, 2024
sogartar
reviewed
Oct 11, 2024
| rope_freq_base = None | ||
|
|
||
| # First we setup and get the default rotary embedding layer | ||
| xq = torch.rand((bs, max_seqlen, heads, rope_dims), dtype=torch.float) |
There was a problem hiding this comment.
You may seed the torch RNG to make sure we get deterministic test results.
monorimet
pushed a commit
that referenced
this pull request
Oct 16, 2024
We should be able to validate the sharded rotary table via comparison with the unsharded version. This runs the sharded and unsharded implementations, asserting near identical results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to validate the sharded rotary table via comparison with the unsharded version. This runs the sharded and unsharded implementations, asserting near identical results.