Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device selection to shortfin llm demo #275

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

renxida
Copy link
Contributor

@renxida renxida commented Oct 11, 2024

No description provided.

@renxida renxida changed the title Shortfin system selection Add device selection to shortfin llm demo Oct 11, 2024
@renxida renxida marked this pull request as ready for review October 14, 2024 16:51
Copy link
Contributor

@monorimet monorimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: good to work this into a proper test structure instead of loose shellscript tests.
Otherwise, LGTM

@renxida
Copy link
Contributor Author

renxida commented Oct 16, 2024

good idea. working it into the pytest infra.

@renxida renxida merged commit 0c48865 into nod-ai:main Oct 17, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants